Skip to content

[NFC] Fix up some warnings #3139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[NFC] Fix up some warnings #3139

wants to merge 1 commit into from

Conversation

Kyle-Ye
Copy link

@Kyle-Ye Kyle-Ye commented Feb 2, 2022

  • parameterString will always return a nil value for Swift 5.3 or later
  • Non-'@objc' class method in extensions cannot be overridden
  • AnyHashable to NSObject will always success
  • Use -Decimal.greatestFiniteMagnitude instead of Decimal.leastFiniteMagnitude

@Kyle-Ye
Copy link
Author

Kyle-Ye commented Feb 2, 2022

@swift-ci Please test

@Kyle-Ye Kyle-Ye changed the title Fix up some warnings [NFC] Fix up some warnings Feb 2, 2022
@Kyle-Ye
Copy link
Author

Kyle-Ye commented Feb 3, 2022

Please test with following PRs:
swiftlang/swift#41115

@swift-ci please test

@Kyle-Ye
Fix up some warnings
343234a 
- parameterString will always return a nil value for Swift 5.3 or later
- Non-'@objc' class method in extensions cannot be overridden
- AnyHashable to NSObject will always success
- Use -Decimal.greatestFiniteMagnitude instead of Decimal.leastFiniteMagnitude
@Kyle-Ye
Copy link
Author

Kyle-Ye commented Oct 2, 2022

@swift-ci please test

@parkera
Copy link
Contributor

parkera commented Jul 19, 2024

Thanks - I fixed up a bunch of warnings in #5000 as well, and I think we got all of these.

@parkera parkera closed this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phausler phausler Awaiting requested review from phausler

@spevans spevans Awaiting requested review from spevans

@millenomi millenomi Awaiting requested review from millenomi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kyle-Ye @parkera